Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retarus Event Collector #38096

Merged
merged 33 commits into from
Jan 29, 2025
Merged

Retarus Event Collector #38096

merged 33 commits into from
Jan 29, 2025

Conversation

YaelShamai
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: (https://jira-dc.paloaltonetworks.com/browse/CIAC-11893)

Description

Retarus event collector

Must have

  • Tests
  • Documentation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway
   RetarusSecureEmailGateway.py731875%149–151, 154–158, 190, 228–231, 233, 239–240, 244, 246
TOTAL731875% 

Tests Skipped Failures Errors Time
4 0 💤 0 ❌ 0 🔥 2.101s ⏱️

@YaelShamai YaelShamai requested a review from JasBeilin January 12, 2025 10:01
JasBeilin
JasBeilin requested changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but I do have some general questions, let discuss about it.

Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
...etarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.py Outdated Show resolved Hide resolved
...etarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.py Outdated Show resolved Hide resolved
...sSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway_test.py Show resolved Hide resolved
...sSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway_test.py Show resolved Hide resolved
Packs/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
Packs/RetarusSecureEmailGateway/pack_metadata.json Outdated Show resolved Hide resolved
...s/SymantecEndpointSecurity/Integrations/SymantecEndpointSecurity/SymantecEndpointSecurity.py Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Jan 22, 2025
ShirleyDenkberg
ShirleyDenkberg reviewed Jan 22, 2025
View reviewed changes
Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
...tarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.yml Outdated Show resolved Hide resolved
...tarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.yml Outdated Show resolved Hide resolved
...EmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway_description.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@JasBeilin Doc review completed.

JasBeilin
JasBeilin reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! check my comments.

Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
Packs/RetarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/README.md Outdated Show resolved Hide resolved
...etarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.py Show resolved Hide resolved
...etarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.py Outdated Show resolved Hide resolved
...etarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.py Show resolved Hide resolved
...etarusSecureEmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway.py Show resolved Hide resolved
...EmailGateway/Integrations/RetarusSecureEmailGateway/RetarusSecureEmailGateway_description.md Outdated Show resolved Hide resolved
@YaelShamai YaelShamai requested a review from JasBeilin January 28, 2025 11:08
JasBeilin
JasBeilin approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@YaelShamai YaelShamai merged commit 0172c8a into master Jan 29, 2025
17 checks passed
@YaelShamai YaelShamai deleted the ys-event-collector branch January 29, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@JasBeilin JasBeilin JasBeilin approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YaelShamai @ShirleyDenkberg @JasBeilin